-
Couldn't load subscription status.
- Fork 1.9k
[DO NOT MERGE]Test duplicate class detection #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huan233usc
wants to merge
74
commits into
delta-io:master
Choose a base branch
from
huan233usc:test-duplicate-class-detection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DO NOT MERGE]Test duplicate class detection #5373
huan233usc
wants to merge
74
commits into
delta-io:master
from
huan233usc:test-duplicate-class-detection
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory to avoid evaluation order issues
- Changed from baseDirectory.getParentFile/spark to (delta-spark-v1/baseDirectory).value - This is more explicit and clearly shows we're using delta-spark-v1's directory - Makes the relationship between modules more obvious
Issue: Test resource directories were using baseDirectory.getParentFile/spark which could evaluate to the wrong path depending on evaluation order. Solution: Changed all test path configurations to consistently use (delta-spark-v1/baseDirectory).value: - Test/unmanagedSourceDirectories - Test/unmanagedResourceDirectories - Test/resourceDirectory - Test/baseDirectory - Test/javaOptions (-Duser.dir) This ensures all test paths correctly point to the spark/ directory regardless of evaluation order, fixing GitHub Actions failures.
…java - build.sbt: Removed old kernelSpark module (replaced by sparkV2 in our refactor) - StreamingHelperTest.java: Use deltaLog.initialCatalogTable() instead of Option.empty()
This commit intentionally adds the same class (DuplicateTestClass) to both sparkV1 and sparkV2 modules to test that the duplicate class detection in build.sbt works correctly. The build should fail with an error message showing the duplicate class. This is a test commit to verify the duplicate detection mechanism works as expected. It should NOT be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?